Filter By Item For Donations Page#5143
Closed
Naraveni wants to merge 2 commits intorubyforgood:mainfrom
Closed
Conversation
Collaborator
|
I think it'll be simplest to hold off on merging this one into main until we get the other fix around this in. |
Collaborator
dorner
requested changes
Sep 5, 2025
| @@ -0,0 +1,32 @@ | |||
| class DonationTotalsService | |||
Collaborator
There was a problem hiding this comment.
This is a query, not a service, no?
| @sources = @donations.collect(&:source).uniq.sort | ||
| @selected_source = filter_params[:by_source] | ||
| @selected_item = filter_params[:by_item_id] | ||
| @donation_totals = DonationTotalsService.call(current_organization.donations.class_filter(scope_filters)) |
Collaborator
There was a problem hiding this comment.
Wait, what does this even have to do with this PR? It's not even used anywhere that I can tell.
Collaborator
|
@Naraveni Are you available to continue with this pr? |
Collaborator
|
I think the easiest thing to do is to start with a fresh PR for this issue; I'm closing this PR and will link to it from the issue for reference. Thanks for the attempt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5105
Description
I have included Filter by Item for donations index page.
Part of the Feature which includes Filter by Category is already covered by #5127 .
Type of change
How Has This Been Tested?
Included a system spec to test this new features
Screenshots